change custom_types contract to be equivalent to the one in soroban-cli #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
approved these changes
Jun 20, 2024
|
Note that a CI test for the custom_types contract is now failing |
willemneal
approved these changes
Jun 20, 2024
|
formatting should be fixed now |
willemneal
approved these changes
Jun 24, 2024
|
@BlaineHeffron @ElliotFriend @fnando, one Test is failing and I can't seem to have the permissions to re-run it. |
willemneal
approved these changes
Jun 26, 2024
fnando
approved these changes
Jun 27, 2024
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changing custom_types contract to match the one in stellar-cli.
Why
This allows us to use
soroban client initin thejs-stellar-sdkinstead of using prebuilt wasms. We needed functions to do tests on. I noticed that custom_types in this repo was identical to increment so I figured it was fine to change it.Close stellar/js-stellar-sdk#980
Known limitations
N/A